chore(iterators): create Iterator module and migrate iterators to use it #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
requested changes
Jul 3, 2022
lua/nvim-tree/iterator.lua
Outdated
| local Iterator = {} | ||
| Iterator.__index = Iterator | ||
|
|
||
| function Iterator.new(nodes) |
There was a problem hiding this comment.
This is really a NodeIterator; we can call it that. More iterators can be added in the future, including a generic one.
All functions except match and apply are node specific. The could go in an AbstractIterator parent class, but that can come when more iterators are added.
lua/nvim-tree/actions/expand-all.lua
Outdated
| if node.open then | ||
| if iterate(node) then | ||
| return true | ||
| Iterator.new(parent.nodes) |
There was a problem hiding this comment.
I love the fluid nature. This is classic builder pattern. Perhaps we could make the naming more concise e.g.
NodeIterator.builder(parent.nodes)
:hidden()
:matcher(...)
:applier(...)
:recursor(...)
:build()()The :build()() is a bit redundant and implies that we have an intermediate NodeIteratorBuilder which doesn't add much value, so :consume() or iterate() is appropriate.
lua/nvim-tree/iterator.lua
Outdated
| end | ||
|
|
||
| function Iterator:allow_hidden() | ||
| self._filter_hidden = function(_) |
There was a problem hiding this comment.
/nit this could just be a boolean member.
kyazdani42
force-pushed
the
chore/refactor-iterators
branch
from
b17b22f to
10aa799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing one iterator (see TODO comment), because i'm not sure about the interface. This is a first attempt to clean up the repetitive code for iterators.
Not sure this is the best implementation i could go with, but it works for now.